Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Higher z-index for the mention plugin suggestions #604

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Higher z-index for the mention plugin suggestions #604

merged 1 commit into from
Jun 20, 2018

Conversation

igorschoester
Copy link
Member

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an issue where in cases with a lot of snippet variables it would sometimes be partially hidden behind the WordPress toolbar.

Relevant technical choices:

  • Increased the z-index by 1000, because this is the value of the element it was behind has as z-index.

Test instructions

This PR can be tested by following these steps:

  • See issue.

Fixes Yoast/wordpress-seo#10045

@danielFangstrom
Copy link
Contributor

CR 👍

@danielFangstrom
Copy link
Contributor

ACC 👍

@danielFangstrom danielFangstrom merged commit 7db9dd8 into develop Jun 20, 2018
@danielFangstrom danielFangstrom deleted the stories/fix-replacevar-suggestions-overlap-issue branch June 20, 2018 08:54
@abotteram abotteram added this to the 4.3 milestone Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@igorschoester @danielFangstrom @abotteram