Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YoastCS: always flag comma spacing in function calls #378

Merged
merged 1 commit into from
Apr 7, 2024
Merged

YoastCS: always flag comma spacing in function calls #378

merged 1 commit into from
Apr 7, 2024

Commits on Apr 7, 2024

  1. YoastCS: always flag comma spacing in function calls 

    The `Universal.WhiteSpace.CommaSpacing` has modular error codes to allow for preventing duplicate error messages about the same issue from different sniffs.

WordPressCS excludes the "function call" related error codes from the sniff to prevent an overlap with the `Generic.Functions.FunctionCallArgumentSpacing` sniff, but this doesn't play nice with a code base using short arrays as the spacing after commas in a short array being passed as a parameter in a function call will then also be skipped.

This change prevents this issue and ensures that the spacing around those commas will be checked correctly.
    @jrfnl
    jrfnl committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    0a8024e View commit details
    Browse the repository at this point in the history