Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message when there are errors in bottender.config.js #611

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

chentsulin
Copy link
Collaborator

When any syntax errors happen in bottender.config.js, it should show those errors instead of failing silently.

@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #611 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
- Coverage   80.83%   80.79%   -0.04%     
==========================================
  Files          95       95              
  Lines        4268     4270       +2     
  Branches     1034     1046      +12     
==========================================
  Hits         3450     3450              
+ Misses        781      779       -2     
- Partials       37       41       +4
Impacted Files Coverage Δ
packages/bottender/src/cli/index.ts 0% <0%> (ø) ⬆️
...ackages/bottender/src/shared/getBottenderConfig.ts 50% <0%> (-12.5%) ⬇️
packages/create-bottender-app/src/shared/log.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768a606...d62415f. Read the comment docs.

@chentsulin chentsulin merged commit 1bc3220 into master Jan 2, 2020
@chentsulin chentsulin deleted the improve-config-errors branch January 2, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants