fix(Bot, LineConnector, MessengerConnector): when receiving multiple events, construct session with event instead of request #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chentsulin
changed the title
chentsulin
force-pushed
the
fix-multiple-event-in-a-request
branch
2 times, most recently
from
d7825fa to
7204ed1
Compare
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
==========================================
+ Coverage 80.79% 80.81% +0.01%
==========================================
Files 95 95
Lines 4270 4284 +14
Branches 1046 1052 +6
==========================================
+ Hits 3450 3462 +12
Misses 779 779
- Partials 41 43 +2
Continue to review full report at Codecov.
|
…events, construct session with event instead of request
chentsulin
force-pushed
the
fix-multiple-event-in-a-request
branch
from
7204ed1 to
9711370
Compare
tw0517tw
approved these changes
Jan 8, 2020
chentsulin
added a commit
that referenced
this pull request
Jan 8, 2020
…events, construct session with event instead of request (#621)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #240
In this PR, I don't want to introduce any breaking changes to Connector API interface, so It's acceptable to support both request body and event in
LineConnectorandMessengerConnector. (support request body as parameter until v2)Todo: