Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Context): add context.setAsHandled() and context.setAsNotHandled() #624

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

chentsulin
Copy link
Collaborator

@chentsulin chentsulin commented Jan 13, 2020

Add following API for tracking handling status:

context.setAsHandled();
context.setAsHandled(false);
context.setAsNotHandled();

TODOs:

  • Add tests

  • Use context.setAsHandled, context.setAsNotHandled in following packages:

  • @bottender/dialogflow

  • @bottender/luis

  • @bottender/qna-maker

  • @bottender/rasa

@chentsulin chentsulin force-pushed the set-as-handled branch 4 times, most recently from 828fa84 to bb8c9df Compare January 13, 2020 12:20
@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #624 into release/1.2 will decrease coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.2     #624      +/-   ##
===============================================
- Coverage        80.95%   80.66%   -0.29%     
===============================================
  Files               99       99              
  Lines             4357     4287      -70     
  Branches          1061     1061              
===============================================
- Hits              3527     3458      -69     
+ Misses             790      789       -1     
  Partials            40       40
Impacted Files Coverage Δ
packages/bottender/src/console/ConsoleContext.ts 100% <ø> (ø) ⬆️
packages/bottender/src/viber/ViberContext.ts 92.85% <ø> (+0.43%) ⬆️
...ckages/bottender/src/messenger/MessengerContext.ts 96.99% <ø> (-0.22%) ⬇️
packages/bottender/src/telegram/TelegramContext.ts 53.08% <ø> (-4.51%) ⬇️
packages/bottender/src/slack/SlackContext.ts 86.2% <ø> (-2.53%) ⬇️
packages/bottender/src/line/LineContext.ts 71.95% <ø> (-0.59%) ⬇️
packages/bottender-qna-maker/src/index.ts 94.73% <100%> (+0.98%) ⬆️
packages/bottender/src/context/Context.ts 95.83% <100%> (+0.27%) ⬆️
packages/bottender-dialogflow/src/index.ts 95% <100%> (+0.55%) ⬆️
packages/bottender-rasa/src/index.ts 89.47% <100%> (+1.23%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1dc152...c51d52a. Read the comment docs.

@chentsulin chentsulin marked this pull request as ready for review January 13, 2020 17:15
@chentsulin chentsulin requested a review from wtflink January 14, 2020 06:04
@chentsulin chentsulin merged commit 71d2ae2 into release/1.2 Jan 14, 2020
@chentsulin chentsulin deleted the set-as-handled branch January 14, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants