Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (slack) : use signing secret in create-bottender-app #659

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

darkbtf
Copy link
Contributor

@darkbtf darkbtf commented Feb 18, 2020

replace verification with signing secret for create-bottender-app

dependency: #652

@darkbtf darkbtf changed the base branch from master to release/1.3 February 18, 2020 09:56
@darkbtf darkbtf changed the title feat : use signing secret in create-bottender-app feat (slack) : use signing secret in create-bottender-app Feb 18, 2020
@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

Merging #659 into release/1.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.3     #659   +/-   ##
============================================
  Coverage        81.06%   81.06%           
============================================
  Files              101      101           
  Lines             4335     4335           
  Branches          1078     1078           
============================================
  Hits              3514     3514           
  Misses             776      776           
  Partials            45       45
Impacted Files Coverage Δ
...s/create-bottender-app/src/utils/generateConfig.ts 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956540c...71110f0. Read the comment docs.

@chentsulin chentsulin merged commit 6d409f5 into release/1.3 Feb 20, 2020
@chentsulin chentsulin deleted the signing-secret-in-template branch February 20, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants