Skip to content

Commit

Permalink
renaming and cleaning up the codebase
Browse files Browse the repository at this point in the history
  • Loading branch information
YongHee-Kim committed Jun 25, 2024
1 parent 2c6ac09 commit 24d540d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/JSONPointer.jl
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ using OrderedCollections, TypedDelegation

include("pointer.jl")
include("pointerdict.jl")
include("dict_interface.jl")
include("abstractdict_interface.jl")

export @j_str, PointerDict, has_pointer, get_pointer, set_pointer!

Expand Down
File renamed without changes.
3 changes: 1 addition & 2 deletions src/pointer.jl
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ Base.:(==)(a::Pointer{U}, b::Pointer{U}) where {U} = a.tokens == b.tokens
# ==============================================================================

_checked_get(collection::AbstractArray, token::Int) = collection[token]

_checked_get(collection::AbstractDict, token::String) = get_pointer(collection, token)

function _checked_get(collection, token)
Expand Down Expand Up @@ -242,7 +241,7 @@ _convert_v(v::U, ::Pointer{U}) where {U} = v
function _convert_v(v::V, p::Pointer{U}) where {U, V}
v = ismissing(v) ? _null_value(p) : v
try
#Conversion to OrderedDict is deprecated for unordered associative containers. Need to be sorted before the conversion
# Conversion to OrderedDict is deprecated for unordered associative containers. Have to be sorted before the conversion
if eltype(p) <: OrderedDict
if <:(V, OrderedDict) == false
return convert(eltype(p), sort!(OrderedDict(v)))
Expand Down

2 comments on commit 24d540d

@YongHee-Kim
Copy link
Owner Author

@YongHee-Kim YongHee-Kim commented on 24d540d Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

Release notes:

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/109747

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.5.0 -m "<description of version>" 24d540da88453f39741e03831e0be8b1579fd443
git push origin v0.5.0

Please sign in to comment.