Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf improvements #356

Merged
merged 18 commits into from
Mar 1, 2024
Merged

Perf improvements #356

merged 18 commits into from
Mar 1, 2024

Conversation

Yooooomi
Copy link
Owner

@Yooooomi Yooooomi commented Mar 1, 2024

No description provided.

quentinguidee and others added 18 commits February 29, 2024 08:07
Signed-off-by: Quentin Guidée <git@arra.red>
Signed-off-by: Quentin Guidée <git@arra.red>
Signed-off-by: Quentin Guidée <git@arra.red>
Signed-off-by: Quentin Guidée <git@arra.red>
Signed-off-by: Quentin Guidée <git@arra.red>
Signed-off-by: Quentin Guidée <git@arra.red>
Signed-off-by: Quentin Guidée <git@arra.red>
Signed-off-by: Quentin Guidée <git@arra.red>
Signed-off-by: Quentin Guidée <git@arra.red>
Signed-off-by: Quentin Guidée <git@arra.red>
Signed-off-by: Quentin Guidée <git@arra.red>
@Yooooomi
Copy link
Owner Author

Yooooomi commented Mar 1, 2024

@quentinguidee If you're good with that we can merge to master, and possibly release 1.8.0 tomorrow (in 12 hours in my country).

@quentinguidee
Copy link
Contributor

quentinguidee commented Mar 1, 2024

The /gethistory seems still pretty slow for no reasons? Or am I missing something?

Other than that I think it's ready for 1.8.0!

@Yooooomi
Copy link
Owner Author

Yooooomi commented Mar 1, 2024

It's really not that slow for me, or what do you mean by slow?

@quentinguidee
Copy link
Contributor

I mean it takes more than 1 second for only some last tracks, that seems slow compared to other requests that perform more complex computations

@Yooooomi
Copy link
Owner Author

Yooooomi commented Mar 1, 2024

So weird to be able to spam click the ranks on the artist page. Every page loads nearly instantaneously. I just spent 15 minutes exploring my stats. Thanks a lot for the work and the motivation you gave me to improve the project.

@Yooooomi Yooooomi merged commit bba31e0 into master Mar 1, 2024
@Karakazz
Copy link

Karakazz commented Mar 3, 2024

So weird to be able to spam click the ranks on the artist page. Every page loads nearly instantaneously. I just spent 15 minutes exploring my stats. Thanks a lot for the work and the motivation you gave me to improve the project.

The feel of the app is entirely different! It feels really nice to click on 'All' and get your entire stats in a few seconds compared to waiting 30-60 seconds. I have been using your_spotify for close to a year now and it was definitely fun clicking through all the stats again :D
| GET /spotify/songs_per?start=2019-01-12T15:09:23.000Z&end=2024-03-03T01:35:31.624Z&timeSplit=all 304 2267.107 ms - -
120110 songs listened

Great work!

@Yooooomi Yooooomi deleted the perf-improvements branch March 12, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants