feat: rework sider design #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinguidee
force-pushed
the
feat/rework-sider
branch
from
8d46d5d
to
5549df2
Compare
|
Dude you got no chill haha. It seems cool. Is light mode working as intended? Is responsive still ok? |
quentinguidee
force-pushed
the
feat/rework-sider
branch
from
5549df2
to
938bf21
Compare
|
Here are screenshots for dark mode: 
And responsive seems to work fine! |
|
It looks really good 👍 |
|
I guess we can just have the hover state persist when on the page |
A bit darker or lighter, but yes. |
|
Lighter on dark mode, darker on light mode |
Yooooomi
requested changes
Mar 2, 2024
apps/client/src/components/Layout/Sider/SiderCategory/index.module.css
Outdated
Show resolved
Hide resolved
apps/client/src/components/Layout/Sider/SiderCategory/index.module.css
Outdated
Show resolved
Hide resolved
quentinguidee
force-pushed
the
feat/rework-sider
branch
from
938bf21
to
9d2df34
Compare
|
This way? Enregistrement.d.ecran.le.2024-03-02.a.13.26.20.mov |
Signed-off-by: Quentin Guidée <git@arra.red>
quentinguidee
force-pushed
the
feat/rework-sider
branch
from
9d2df34
to
2198e7a
Compare
|
Maybe full white written in black when focused |
Thats the same too big contrast as on the search before. |
Yooooomi
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some design refinements for the drawer