Fixed Review Export issues. #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$io object referred to nothing. Fixed multiple unwanted version of file creation while exporting review to replace by a single new file.
Fixed unwanted exportData action execution as exportReviews action already creates the export file. Auto file download after export.
Update ExportController.php
Update Csv.php
Revert "Update ExportController.php"
Revert "Revert "Update ExportController.php""
|
FWIW, in my M 1.9 instance, the export-reviews feature works only after applying the modifications in this PR (including the changes to ExportController.php). |
kmdsax
reviewed
Apr 25, 2018
| $file_content = file_get_contents($baseDir . $fileName); | ||
| if ($file_content) { | ||
| $this->getResponse()->setHeader('Content-type', 'application/csv'); | ||
| $this->getResponse()->setBody($file_content); |
There was a problem hiding this comment.
The filename needs to be set in the header in order to be downloaded as "review_export.csv", otherwise it will be downloaded as a generic "download" file without a file extension:
$this->getResponse()->setHeader('Content-Disposition', 'attachment; filename="' . $fileName . '"');
Fixed filename issue for downloaded file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed review export issue and download file without calling another controller "exportData" action.