Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-sleep #398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file.
3 changes: 3 additions & 0 deletions src/main/scala/com/yotpo/metorikku/metric/Metric.scala
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ case class Metric(configuration: Configuration, metricDir: Option[File], metricN
log.info(s"Starting to Write results of ${dataFrameName}")
try {
writer.write(dataFrame)
//TODO: wait for the hook
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ron suggests to try to use flush inestead of send in the kafka reporter, maybe it will send before the process stops

val millis = 20000
Thread.sleep(millis)
outputConfig.reportLag match {
case Some(true) => new MetricReporting().reportLagTime(dataFrame, outputConfig.reportLagTimeColumn,
outputConfig.reportLagTimeColumnUnits, instrumentationProvider)
Expand Down