Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(periodic): fix periodic not working #448

Merged
merged 1 commit into from
Aug 9, 2021
Merged

fix(periodic): fix periodic not working #448

merged 1 commit into from
Aug 9, 2021

Conversation

lyogev
Copy link
Contributor

@lyogev lyogev commented Aug 9, 2021

No description provided.

amirhalatzi
amirhalatzi suggested changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@amirhalatzi amirhalatzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard will it be to add some basic tests to this feature?

@lyogev lyogev merged commit 0a7e297 into master Aug 9, 2021
@lyogev lyogev deleted the fix_periodic branch August 9, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirhalatzi amirhalatzi amirhalatzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyogev @amirhalatzi