-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate test data #266
Merged
Merged
Separate test data #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying website with Cloudflare Pages
|
MrGreenTea
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just a few small clean ups would be nice
Han2-Ro
force-pushed
the
han2-ro/refactor/separate-test-data
branch
from
November 15, 2024 11:12
ecdf222
to
c9192ae
Compare
MrGreenTea
approved these changes
Nov 15, 2024
MrGreenTea
force-pushed
the
han2-ro/refactor/separate-test-data
branch
from
November 20, 2024 17:35
b565bb7
to
a963cfb
Compare
real and test implementation of DataGetter by splitting functions
add getAllYearlyEvents to EventData interface and use const eventData form index.ts in Components
Han2-Ro
force-pushed
the
han2-ro/refactor/separate-test-data
branch
from
November 22, 2024 10:24
39f634f
to
b73a378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.