Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLs in $ref should be url encoded #617

Open
DavideCanton opened this issue Nov 15, 2024 · 0 comments · May be fixed by #618
Open

URLs in $ref should be url encoded #617

DavideCanton opened this issue Nov 15, 2024 · 0 comments · May be fixed by #618

Comments

@DavideCanton
Copy link

When generating definitions for generic types (say Foo), $ref urls to them may be invalid URL, as #/defintions/Foo<T> should be escaped to be considered a valid fragment.

It should be enough to uri encode the $ref, the name of the generated type can remain Foo<T>
@DavideCanton DavideCanton mentioned this issue Nov 15, 2024
Closed
2 tasks
DavideCanton added a commit to DavideCanton/typescript-json-schema that referenced this issue Nov 15, 2024
@DavideCanton
feat: uri encoded $refs (YousefED#617)
0c26ce7
@DavideCanton DavideCanton linked a pull request Nov 15, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: uri encoded $refs (#617) DavideCanton/typescript-json-schema
1 participant
@DavideCanton