Skip to content

Added a project resolver to decide which project is installed. Also a… #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

leonhelmus
Copy link

…dded a config to overwrite the type used.

  • A project resolver to decide which project is installed. Also added a config to overwrite the type used.

  • Composer requirement which should have already been there.

  • Make patches independent on project type.

  • Files mapping to make clear which platforms the files are used for.

…dded a config to overwrite the type used.

- A project resolver to decide which project is installed. Also added a config to overwrite the type used.
- Composer requirement which should have already been there.

- Make patches independent on project type.
- Files mapping to make clear which platforms the files are used for.
@hkruit hkruit self-requested a review April 22, 2022 09:36
## 2.4.0 - 2022-04-13
### Added
- A project resolver to decide which project is installed. Also added a config to overwrite the type used.
- Composer requirement which should have already been there.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could be more explicit here, as in

Fixed (we did not add a feature, we fixed a problem)

  • Added missing composer dependency to package X

Copy link
Member

@igorwulff igorwulff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @leonhelmus is this PR still relevant? Things seem ok in this PR, but it is almost 1 year old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants