Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable minor features #533

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Disable minor features #533

merged 5 commits into from
Apr 9, 2024

Conversation

koron
Copy link
Collaborator

@koron koron commented Mar 26, 2024

Disabled features

  • GRAVE_ESC_ENABLE = no (80 bytes)
  • Magic functions (570 bytes)

Others:

  • Remove define SPLIT_USB_TIMEOUT 500, therefore default 2000 msec is applied. This may help in some environments where Keyball is not recognized
  • Fix description of keycodes

koron added 5 commits April 6, 2024 13:17
Override two functions which is used for customizing the magic keycode.
See https://docs.qmk.fm/#/squeezing_avr?id=magic-functions also.

This fix reduces the firmware size by 578 bytes.
@okuRaku
Copy link

okuRaku commented Apr 6, 2024

突然のコメントで失礼します。

私は自作キーボード自体素人で今日手に入れたばかりのkeyball61キットすら組み立て始めてないのですが、事前準備としてkeymapを勉強していましたところ、KC_GRV (`)の入力方法がどうも見つかりませんでした。さらに探ったら、このPRを見つけました。もしかしてKC_GRVを入力するために、QMKのGRAVE_ESC_ENABLE機能が利用されているでしょうか? その場合、無効化されたら、viaマップでどうやってKC_GRVを入力できるのでしょうか?

私の知識が足りないだけで入力方法ほかにあるでしょうと、思いながらコメントさせていただきました。 申し訳ありません。

@koron
Copy link
Collaborator Author

koron commented Apr 8, 2024

@okuRaku コメントをありがとうざいます!

GRAVE_ESC_ENABLEKC_GRV とは直接の関係がない機能です。
そのためKeyball 61のデフォルトキーマップに KC_GRV が存在しないのは
独立した問題であると考えられます。

GRAVE_ESC_ENABLEQK_GRAVE_ESCAPE (および QK_GESC )というキーコードを増やす機能です。
このキーコードは単一で入力されると GRAVE ~ に、modifier keys と合わせると ESC として解釈される特殊なものです。

詳しくはこちらをご覧ください。
https://docs.qmk.fm/#/feature_grave_esc

マイナーな機能であるためデフォルトのファームウェアからは消しても良いと考えています。


Thank you for your comment!

GRAVE_ESC_ENABLE feature doesn't relate with KC_GRV keycode directly.
Therefore, the absence of KC_GRV in the default keymap of Keyball 61 is considered to be an independent problem.

GRAVE_ESC_ENABLE is a feature that increases key codes QK_GRAVE_ESCAPE and QK_GESC.
These keycodes are special keycodes that when typed alone are interpreted as GRAVE ~ and when combined with a modifier key are interpreted as ESC.

See https://docs.qmk.fm/#/feature_grave_esc for detail.

Since it is a minor feature, I think it is okay to remove it from default firmwares.

@okuRaku
Copy link

okuRaku commented Apr 8, 2024

Thank you very much for your reply!

I think my confusion was, looking at the recommended via keymap in this repo I could not find any way to enter the grave (`) key. Therefore, I mistakenly assumed it must rely on this functionality.

If it is not related, may I ask directly, how do we input grave (`) with the recommend via layout?

I apologize for my question based on lack of understanding and experience. Thank you for any further information!

Of course I have no objection to the change in this PR!

@okuRaku
Copy link

okuRaku commented Apr 8, 2024

Sorry again for my question unrelated to the change. I also did not realize it utilized those QK_ keycodes. I think after I have more experience I will understand. Feel free to ignore!! Thank you.

@koron
Copy link
Collaborator Author

koron commented Apr 8, 2024

@okuRaku Don't hesitate 👍

Your question is originally caused by the difficulty of understanding QMK, Keyball, and this PR,
and in most cases, there is a lack of documentation.
I believe that this discussion will increase its documentation and help others in the future.

This is very valuable.

@koron koron marked this pull request as ready for review April 9, 2024 01:50
@koron koron merged commit 778e565 into Yowkees:main Apr 9, 2024
20 checks passed
@koron koron deleted the disable-minor-features branch April 9, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants