Vignette updates #170
Vignette updates #170
Conversation
There was a problem hiding this comment.
Really huge improvements! Thanks so much for taking this on and doing such a lovely job.
I left some minor comments, none of which should block merging this PR. I haven't looked at the vignettes in the context of the pkgdown site, but we'll be able to see that once it's merged and can address any issues then, so feel free to merge when you have a moment.
Please remember to squash and merge.
There was a problem hiding this comment.
Not critical, but any chance we can make this a pdf instead of png?
There was a problem hiding this comment.
You've definitely made some big improvements to the flow and readability of the this vignette.
Non-blocking for this PR, but do you think it would be possible to make this version build upon the simChef.Rmd rather than repeating what is already covered there? Then it would be a more advanced sequel rather than simply a more detailed version of the same, and hopefully we could cut it down a bit more. Something to think about but let's not worry about it for now.
There was a problem hiding this comment.
Yeah, I think that would be good for the future. I was also thinking about whether or not to do this. I figured it could be beneficial to have another example for now. In the long-run, I think having (a) a separate collection of simChef examples plus (b) a comprehensive guide that builds on the introductory version would be ideal.
Update vignettes:
Close #160