Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/1.12 updates #165

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Docs/1.12 updates #165

merged 4 commits into from
Dec 17, 2024

Conversation

equijano21
Copy link
Collaborator

Description

Documentation updates for 1.12 in progress.

@equijano21 equijano21 marked this pull request as draft December 16, 2024 04:46
Copy link

github-actions bot commented Dec 16, 2024

Test Results: Windows

    2 files      2 suites   4s ⏱️
3 703 tests 3 703 ✅ 0 💤 0 ❌
3 705 runs  3 705 ✅ 0 💤 0 ❌

Results for commit 453c20f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 16, 2024

Test Results: Ubuntu

    2 files      2 suites   10s ⏱️
3 695 tests 3 695 ✅ 0 💤 0 ❌
3 697 runs  3 697 ✅ 0 💤 0 ❌

Results for commit 453c20f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 16, 2024

Test Results: MacOS

    2 files      2 suites   4s ⏱️
3 695 tests 3 695 ✅ 0 💤 0 ❌
3 697 runs  3 697 ✅ 0 💤 0 ❌

Results for commit 453c20f.

♻️ This comment has been updated with latest results.

@@ -38,7 +38,7 @@ namespace Yubico.YubiKey.Piv.Commands
/// information on how to use this authentication.
/// </para>
/// <para>
/// Upon manufacture of a YubiKey, the management key is a Triple-DES key and
/// Upon manufacture of a YubiKey, the management key is either a Triple-DES key (firmware prior to 5.7) or an AES-192 key (firmware 5.7 and later), and
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates for YESDK-1409

Comment on lines +142 to +143
/// This class will also need a random number generator and Triple-DES and AES
/// encryptors/decryptors. It will get them from
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates for YESDK-1409

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed formatting issues that caused the regular text below the code as well as the Warning callout box to not render properly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates for YESDK-1409

@equijano21 equijano21 marked this pull request as ready for review December 17, 2024 04:09
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 43% 32% 4221
Yubico.YubiKey 50% 47% 19155
Summary 49% (32252 / 66084) 44% (8188 / 18579) 23376

Minimum allowed line rate is 40%

@DennisDyallo DennisDyallo merged commit 67a4100 into develop Dec 17, 2024
12 checks passed
@DennisDyallo DennisDyallo deleted the docs/1.12-updates branch December 17, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants