fix: ConnectionFactory incorrectly using SmartCardConnection

[DennisDyallo]

Description

The ConnectionFactory incorrectly selected the SmartCardConnection instead of the FIDO2Connection

Fixes: #178

Type of change

• Refactor (non-breaking change which improves code quality or performance)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test configuration:

• OS version: e.g. Windows 11
• Firmware version: 5.4.3 and 5.7.2 keys
• Yubikey model¹:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have run dotnet format to format my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Footnotes

1. See Yubikey models (Multi-protocol, Security Key, FIPS, Bio, YubiHSM, YubiHSM FIPS) ↩

[github-actions]

Test Results: Windows

    2 files      2 suites   4s ⏱️
3 741 tests 3 741 ✅ 0 💤 0 ❌
3 743 runs  3 743 ✅ 0 💤 0 ❌

Results for commit 1160d51.

♻️ This comment has been updated with latest results.

[github-actions]

Test Results: Ubuntu

    2 files      2 suites   9s ⏱️
3 733 tests 3 733 ✅ 0 💤 0 ❌
3 735 runs  3 735 ✅ 0 💤 0 ❌

Results for commit 1160d51.

♻️ This comment has been updated with latest results.

[github-actions]

Test Results: MacOS

    2 files      2 suites   4s ⏱️
3 733 tests 3 733 ✅ 0 💤 0 ❌
3 735 runs  3 735 ✅ 0 💤 0 ❌

Results for commit 1160d51.

♻️ This comment has been updated with latest results.

[github-actions]

Package	Line Rate	Branch Rate	Complexity	Health
Yubico.Core	44%	32%	4311	➖
Yubico.YubiKey	49%	46%	19665	➖
Summary	48% (32931 / 68502)	43% (8248 / 18984)	23976	➖

Minimum allowed line rate is 40%

[AdamVe]

LGTM