Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributor templates for issues and pull requests #74

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

DennisDyallo
Copy link
Collaborator

@DennisDyallo DennisDyallo commented Apr 12, 2024

Description

Added contributor templates to facilitate collaboration

Type of change

Workflow

How Has This Been Tested?

Set up in a private repo and observed the outcome here: https://github.com/DennisDyallo/tools/issues/new/choose

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have run dotnet format
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@DennisDyallo DennisDyallo changed the base branch from dennisdyallo/setup-dotnet to develop April 12, 2024 10:41
@DennisDyallo DennisDyallo changed the title Dennisdyallo/add-contributor-templates Add contributor templates for issues and pull requests Apr 12, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 43% 32% 1409
Yubico.YubiKey 53% 48% 6085
Summary 51% (8294 / 16290) 45% (2662 / 5929) 7494

Minimum allowed line rate is 50%

Copy link

Test Results

    2 files  ±0      2 suites  ±0   2s ⏱️ ±0s
3 615 tests ±0  3 615 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 617 runs  ±0  3 617 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2354db8. ± Comparison against base commit 043119a.

This pull request removes 25 and adds 25 tests. Note that renamed tests count towards both.
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-12T08:34:45.6084997+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: Fido2)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-12T08:34:45.6084997+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: FidoU2f)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-12T08:34:45.6085207+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: Otp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: Fido2)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: FidoU2f)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: Management)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: Oath)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: OpenPgp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: Otp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-12T08:34:45.6085907+00:00, ParentDeviceId = null, Path = "" }, application: Piv)
…
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-16T13:48:30.6785419+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: Fido2)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-16T13:48:30.6785419+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: FidoU2f)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestHidDevice { LastAccessed = 2024-04-16T13:48:30.6785629+00:00, ParentDeviceId = null, Path = "", ProductId = 0, Usage = 0, ··· }, application: Otp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-16T13:48:30.6786321+00:00, ParentDeviceId = null, Path = "" }, application: Fido2)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-16T13:48:30.6786321+00:00, ParentDeviceId = null, Path = "" }, application: FidoU2f)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-16T13:48:30.6786321+00:00, ParentDeviceId = null, Path = "" }, application: Management)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-16T13:48:30.6786321+00:00, ParentDeviceId = null, Path = "" }, application: Oath)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-16T13:48:30.6786321+00:00, ParentDeviceId = null, Path = "" }, application: OpenPgp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-16T13:48:30.6786321+00:00, ParentDeviceId = null, Path = "" }, application: Otp)
Yubico.YubiKey.ConnectionManagerTests ‑ DeviceSupportsApplication_GivenSupportedTuple_ReturnsTrue(device: TestSmartCardDevice { Atr = null, Kind = Any, LastAccessed = 2024-04-16T13:48:30.6786321+00:00, ParentDeviceId = null, Path = "" }, application: Piv)
…

@DennisDyallo DennisDyallo merged commit 13aea4b into develop Apr 16, 2024
6 checks passed
@DennisDyallo DennisDyallo deleted the dennisdyallo/add-contributor-templates branch April 16, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant