-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated/disabled cloud upload. #363
Conversation
&& privateIdInput.acceptableInput | ||
&& secretKeyInput.acceptableInput | ||
toolTipText: qsTr("Finish and write the configuration to the YubiKey") | ||
Layout.alignment: Qt.AlignRight | Qt.AlignBottom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The qt now complains that the property is set multiple times:
qrc:/qml/OtpYubiOtpView.qml:160:17: Property value set multiple times
so I think this one can be removed.
This lead to issues described in the last comments of #357 in Fedora, where I pulled this patch to.
Hi @Jakuje, since upstream no longer actively develops the project I will not try to get this working. I have switched to the new authenticator app which works fine on Fedora (if someone wants to invest time in yubikey support in Fedora it might be more beneficial to put it into packaging the new app instead of keeping the old one on life support).
…On Tue, Sep 3, 2024, at 10:18, Jakub Jelen wrote:
***@***.**** commented on this pull request.
In ykman-gui/qml/OtpYubiOtpView.qml
<#363 (comment)>:
>
+ onClicked: finish()
+ enabled: publicIdInput.acceptableInput
+ && privateIdInput.acceptableInput
+ && secretKeyInput.acceptableInput
+ toolTipText: qsTr("Finish and write the configuration
to the YubiKey")
+ Layout.alignment: Qt.AlignRight | Qt.AlignBottom
The qt now complains that the property is set multiple times:
`qrc:/qml/OtpYubiOtpView.qml:160:17: Property value set multiple times
`
so I think this one can be removed.
This lead to issues described in the last comments of #357
<#357> in Fedora,
where I pulled this patch to.
—
Reply to this email directly, view it on GitHub
<#363 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAT5C3SSMPKDIV23W7WA7TZUVWERAVCNFSM6AAAAABLCQP3PGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZWG4YTSNJVGQ>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No problem. I just wanted to put a comment here if somebody would like to reuse your patch for their use case to avoid spending more time debugging the same issue. |
Anyway, I will add packaging of the Yubico Authenticator to my to-do list, if nobody will pick it up earlier. |
@Jakuje That would be lovely. I have read in the past that since it is based on flutter that there might be some issues with packaging (distant memory though, might be wrong). If there is anything I can help with, even if you just need a second set of eyes/ears feel free to ping me. |
I discussed the authenticator situation in Fedora here: yubioath-desktop will not be available in the F38 Fedora repository TLDR:
Several Different Mitigation paths are available
For more information on ykocli refer to the wiki |
This is a follow up to Yubico/yubikey-manager@2bcf81b and restores GUI functionality again.
Untested, since I am currently not able to compile this on my own (having conflicts somewhere in the QtQuick versions)