Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated/disabled cloud upload. #363

Closed
wants to merge 1 commit into from
Closed

Remove deprecated/disabled cloud upload. #363

wants to merge 1 commit into from

Conversation

apollo13
Copy link

@apollo13 apollo13 commented Jul 18, 2024

This is a follow up to Yubico/yubikey-manager@2bcf81b and restores GUI functionality again.

Untested, since I am currently not able to compile this on my own (having conflicts somewhere in the QtQuick versions)

&& privateIdInput.acceptableInput
&& secretKeyInput.acceptableInput
toolTipText: qsTr("Finish and write the configuration to the YubiKey")
Layout.alignment: Qt.AlignRight | Qt.AlignBottom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The qt now complains that the property is set multiple times:

qrc:/qml/OtpYubiOtpView.qml:160:17: Property value set multiple times

so I think this one can be removed.

This lead to issues described in the last comments of #357 in Fedora, where I pulled this patch to.

@apollo13
Copy link
Author

apollo13 commented Sep 3, 2024 via email

@Jakuje
Copy link
Contributor

Jakuje commented Sep 3, 2024

No problem. I just wanted to put a comment here if somebody would like to reuse your patch for their use case to avoid spending more time debugging the same issue.

@Jakuje
Copy link
Contributor

Jakuje commented Sep 3, 2024

Anyway, I will add packaging of the Yubico Authenticator to my to-do list, if nobody will pick it up earlier.

@apollo13
Copy link
Author

apollo13 commented Sep 3, 2024

@Jakuje That would be lovely. I have read in the past that since it is based on flutter that there might be some issues with packaging (distant memory though, might be wrong). If there is anything I can help with, even if you just need a second set of eyes/ears feel free to ping me.

@apollo13 apollo13 closed this Sep 3, 2024
@apollo13 apollo13 deleted the remove-cloud-upload branch September 3, 2024 12:06
@gbcox
Copy link

gbcox commented Sep 3, 2024

Anyway, I will add packaging of the Yubico Authenticator to my to-do list, if nobody will pick it up earlier.

I discussed the authenticator situation in Fedora here: yubioath-desktop will not be available in the F38 Fedora repository

TLDR:

Yubico Authenticator is flutter based and flutter is not yet available in Fedora
It appears that the way the package was created and bundled that it would violate current packaging guidelines

Several Different Mitigation paths are available

  • Supported in Fedora: Install today ykocli . This package is a TUI application which will mimic the functionality that was provided by yubioath-desktop. Please report any issues, bugs, etc. via bugzilla so they may be quickly addressed.
  • Supported Upstream: Install the new flutter based yubico-authenticator appimage directly from the yubico website.

For more information on ykocli refer to the wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants