This repository has been archived by the owner on Apr 24, 2021. It is now read-only.
Update ykval-synclib.php #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://secure.php.net/manual/en/function.curl-multi-info-read.php, "The data the returned resource points to will not survive calling curl_multi_remove_handle()." Therefore, it is better to call curl_multi_remove_handle() after we're finished with the handle and its related info data returned from curl_multi_info_read(). Not doing so will make the info data unreadable. This could lead to logging when re-syncing that makes it appear as though syncing is not successful when in reality it is working just fine.
Update ykval-synclib.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://secure.php.net/manual/en/function.curl-multi-info-read.php, "The data the returned resource points to will not survive calling curl_multi_remove_handle()." Therefore, it is better to call curl_multi_remove_handle() after we're finished with the handle's related info data returned by curl_multi_info_read(). Not doing so will make the info data unreadable. This could lead to logging when re-syncing that makes it appear as though syncing is not successful when in reality it is working just fine.