Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spotless gradle plugin for unified formatting #162

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use spotless gradle plugin for unified formatting #162

wants to merge 3 commits into from

Conversation

AdamVe
Copy link
Member

@AdamVe AdamVe commented Dec 20, 2024

Adds spotless setup with Google Java Style and reformats existing java sources.

  • To run the formatting manually: ./gradlew spotlessApply
  • adds pre-commit hook to execute format of java files
  • Spotless also has plugins for IDEs. For Android Studio I recommend to install the google-java-format plugin as well.

Todo:

  • verify formatting on commit and fail builds with invalid formatting with ./gradlew spotlessJavaCheck

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 20, 2024
View reviewed changes
core/src/main/java/com/yubico/yubikit/core/internal/codec/DefaultBase64Codec.java Dismissed Show dismissed Hide dismissed
core/src/main/java/com/yubico/yubikit/core/internal/codec/DefaultBase64Codec.java Dismissed Show dismissed Hide dismissed
oath/src/main/java/com/yubico/yubikit/oath/CredentialIdUtils.java Dismissed Show dismissed Hide dismissed
openpgp/src/main/java/com/yubico/yubikit/openpgp/Pw.java Dismissed Show dismissed Hide dismissed
openpgp/src/main/java/com/yubico/yubikit/openpgp/Pw.java Dismissed Show dismissed Hide dismissed
piv/src/main/java/com/yubico/yubikit/piv/jca/PivCipherSpi.java Dismissed Show dismissed Hide dismissed
piv/src/main/java/com/yubico/yubikit/piv/jca/PivProvider.java Dismissed Show dismissed Hide dismissed
piv/src/main/java/com/yubico/yubikit/piv/jca/PivRsaSignatureSpi.java Dismissed Show dismissed Hide dismissed
testing/src/main/java/com/yubico/yubikit/testing/piv/PivTestUtils.java Dismissed Show dismissed Hide dismissed
yubiotp/src/main/java/com/yubico/yubikit/yubiotp/HmacSha1SlotConfiguration.java Dismissed Show dismissed Hide dismissed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 20, 2024
View reviewed changes
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/ScpState.java Dismissed Show dismissed Hide dismissed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/ScpState.java Dismissed Show dismissed Hide dismissed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/ScpState.java Dismissed Show dismissed Hide dismissed
fido/src/main/java/com/yubico/yubikit/fido/ctap/PinUvAuthProtocolV1.java Dismissed Show dismissed Hide dismissed
fido/src/main/java/com/yubico/yubikit/fido/ctap/PinUvAuthProtocolV1.java Dismissed Show dismissed Hide dismissed
piv/src/main/java/com/yubico/yubikit/piv/jca/PivRsaSignatureSpi.java Dismissed Show dismissed Hide dismissed
testing/src/main/java/com/yubico/yubikit/testing/openpgp/OpenPgpDeviceTests.java Dismissed Show dismissed Hide dismissed
testing/src/main/java/com/yubico/yubikit/testing/openpgp/OpenPgpDeviceTests.java Dismissed Show dismissed Hide dismissed
testing/src/main/java/com/yubico/yubikit/testing/piv/PivJcaDecryptTests.java Dismissed Show dismissed Hide dismissed
testing/src/main/java/com/yubico/yubikit/testing/piv/PivTestUtils.java Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AdamVe