Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialization page and fix various bugs #2

Merged
merged 5 commits into from
Sep 29, 2024

Conversation

ChisatoNishikigi73
Copy link
Collaborator

@ChisatoNishikigi73 ChisatoNishikigi73 commented Sep 28, 2024

This pull request includes updates to the Init component to handle resource loading and progress tracking, as well as a minor enhancement to the LineDecorator component.

Major Changes:

Resource Loading and Progress Tracking:

  • src/components/Init.tsx: Added a new Init component to manage resource loading, including tracking progress, handling state updates, and managing the UI transitions based on loading status.

UI Enhancements:

  • src/components/LineDecorator.tsx: Added a new leftClassName to the LineDecorator component to handle the left border styling dynamically.fix: enhance SVG icon color control(1a5e9b3)

feat: The world page has been preliminarily improved(126b965)

fix: Fix issue of redirecting to #index when reloading the page(8ba2cac)

feat: Add initialization page; now displays before entering main page(70ad8cb)

bug: Extra layout appearing on Information page
Btw Following the position of the image in the mouse in the world page requires a strange offset, I don't know how to fix it

const imgOffsetX = 350;
const imgOffsetY = 0;
const imgOffsetXPercentage = 75;
const imgOffsetYPercentage = 0;
const newPosition = {
  x: x - imgWidth / 2 + (imgOffsetX * imgOffsetXPercentage / 100),
  y: y - imgHeight / 2 + (imgOffsetY * imgOffsetYPercentage / 100)
};

@Yue-plus Yue-plus merged commit 468aa9e into Yue-plus:main Sep 29, 2024
Copy link
Owner

@Yue-plus Yue-plus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常感谢您的贡献!
Thank you so much for your contribution!

src/components/SvgIcons.tsx Show resolved Hide resolved
src/components/Init.tsx Show resolved Hide resolved
src/components/Init.tsx Show resolved Hide resolved
src/components/SvgIcons.tsx Show resolved Hide resolved
src/pages/_views/03-World.tsx Show resolved Hide resolved
ChisatoNishikigi73 added a commit to ChisatoNishikigi73/astro-arknights that referenced this pull request Sep 29, 2024
ChisatoNishikigi73 added a commit to ChisatoNishikigi73/astro-arknights that referenced this pull request Sep 29, 2024
@ChisatoNishikigi73
Copy link
Collaborator Author

All issues have been resolved at #3

Yue-plus added a commit that referenced this pull request Sep 29, 2024
review: Complete review of issue #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants