-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initialization page and fix various bugs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allowing them to better adapt to different themes and design requirements.
…addition of the Init function, it has to be submitted first
Yue-plus
reviewed
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
非常感谢您的贡献!
Thank you so much for your contribution!
ChisatoNishikigi73
added a commit
to ChisatoNishikigi73/astro-arknights
that referenced
this pull request
Sep 29, 2024
ChisatoNishikigi73
added a commit
to ChisatoNishikigi73/astro-arknights
that referenced
this pull request
Sep 29, 2024
All issues have been resolved at #3 |
Yue-plus
added a commit
that referenced
this pull request
Sep 29, 2024
review: Complete review of issue #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
Init
component to handle resource loading and progress tracking, as well as a minor enhancement to theLineDecorator
component.Major Changes:
Resource Loading and Progress Tracking:
src/components/Init.tsx
: Added a newInit
component to manage resource loading, including tracking progress, handling state updates, and managing the UI transitions based on loading status.UI Enhancements:
src/components/LineDecorator.tsx
: Added a newleftClassName
to theLineDecorator
component to handle the left border styling dynamically.fix: enhance SVG icon color control(1a5e9b3)feat: The world page has been preliminarily improved(126b965)
fix: Fix issue of redirecting to #index when reloading the page(8ba2cac)
feat: Add initialization page; now displays before entering main page(70ad8cb)
bug: Extra layout appearing on Information page
Btw Following the position of the image in the mouse in the world page requires a strange offset, I don't know how to fix it