Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions in README to create the DB: ysql_sequelize #46

Merged

Conversation

sibtayshah
Copy link
Contributor

Note that based on our testing we concluded that it is better to make user create the database, rather than the specific ORM trying to do so.
When we made the ORM to manage creation of DB, we were running into various permission issues, hence in order to keep it simple we favored this approach

@sibtayshah
Copy link
Contributor Author

#29

Copy link
Contributor

@rkarthik007 rkarthik007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rkarthik007 rkarthik007 merged commit da5c754 into YugabyteDB-Samples:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants