Skip to content
This repository was archived by the owner on Oct 8, 2022. It is now read-only.

WIP: Add dry-struct compiler #1

Closed
wants to merge 3 commits into from
Closed

Conversation

YukiJikumaru
Copy link
Owner

@YukiJikumaru YukiJikumaru commented Oct 3, 2022

THIS PULL REQUEST IS NOT FOR MERGE

Motivation

Implementation

Tests

@YukiJikumaru YukiJikumaru self-assigned this Oct 3, 2022
@YukiJikumaru YukiJikumaru changed the title wip WIP: Add dry-struct compiler Oct 4, 2022
Copy link

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @YukiJikumaru, thank you for this!
I just wanted to leave a quick comment to let you know that I'm trying your compiler on our project (we also use dry-struct) and I had a couple of issues with missing implementations:

  • visit_map needed when Types::Hash.map is used (see doc)
  • visit_enum needed when Types::String.enum is used (see doc)

There might also be other missing issues, but these were the ones popping up on our project.

I also had to remove some of the code related to Maybe and Monads because they're extensions and we don't use them in our project, so your compiler should probably account for this by only checking them when present :)

@YukiJikumaru
Copy link
Owner Author

@iMacTia Thank you for your advise!

visit_map needed when Types::Hash.map is used (see doc)
visit_enum needed when Types::String.enum is used (see doc)

I also had to remove some of the code related to Maybe and Monads

I fixed these issues on https://github.com/YukiJikumaru/dry_tapioca_compiler .


Due to the circumstances described in the issue below, this repository will be archived and development will continue in https://github.com/YukiJikumaru/dry_tapioca_compiler .

Shopify#1210 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants