Add configurable healthchecks.io URL option #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no easy solution for external monitoring of the backups. Since there's nothing worse than setting up a backup to discover after 6 months (or years) that it stopped working after a couple of days.
Yunohost sending mails alleviates the problem somewhat, but introducing healthchecks is an easy solution with no overhead.
This PR fixes #117 - it can be extended later on by multiple options for backup monitoring, something like the backup-hooks in borgmatic, but it doesn't have to.
Solution
healthchecks_urlthat is called upon success or failure (in the event of failure it includes the logs). You can send this either to your own hosted version of healthchecks.io or to the official one.PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)
EDIT: I could also imagine moving it to "Advanced Options" if that feels better?
Sorry for the force-pushes. Ready for review.