Fix mail encoding and typos #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mail encoding and typos
|
!testme |
|
📚 |
|
🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Mail encoding
In the mails sent from borg at the end of some lines there were these signs
…. See screenshot.Typos
Furthermore, when the backups were successful, the mail subject was like this
[borg] Backup succeed from [...]which is incorrect past tense of succeed.Solution
Mail encoding
The affected lines originate from the borg log files in which instead of
…there are 3 points...at the end of those lines. So, I believe that this is an encoding issue. See https://www.i18nqa.com/debug/utf8-debug.html . I applied the solution suggested here using-aparameter in themailcommand.Typos
I fixed the typos so that the mail subject is like this now
[borg] Backup succeeded from [...]which is correct past tense of succeed. Additionally, I fixed a typo inbackup-with-borg's comments.PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)