Misc improvements #163
Merged
Misc improvements #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that getting the config of a repo is fast, but maybe not?)
Limezy
reviewed
Jun 22, 2024
|
|
||
| # We prune potential manual backup older than 1 year | ||
| "$borg" prune "$repo" --keep-within 1y 2>&1 >/dev/null | log_with_timestamp | ||
| "$borg" prune --list --keep-within 1y |
There was a problem hiding this comment.
@kay0u I'm not very fond of pruning without the user being informed ?
Shouldn't this "1y" be a setting in the config panel, set to "never" by default ?
There was a problem hiding this comment.
This code was already there, it's a discussion for another PR. To me it's very reasonable to have pruning by default because you don't want backup to just pile up and eat space forever. 1 year is a reasonable value ... Most of the time when you need to restore a backup, you need one from say a few days ago ...
There was a problem hiding this comment.
I understand your point. It should at least be mentionned somewhere in the post-install notes for instance.
I'll try to see if I can work on this small matter.
alexAubin
approved these changes
Jun 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
BORG_REPOenv var instead of using$repoall over the placelogging.conffile, and the corresponding env var to manage logs instead of using| tee -aborg prune -Pwithborg prune --glob-archives "regex"because -P is deprecated, and it should fix the mess about pruningappandapps__2(tested on my side by spammingsystemctl start borg.service)--statsand--listto have more infos in logsbackup-with-borg(I think there was a problem here, after a restore thebackup-with-borgfile shouldn't exist if I read the code correctly)/var/log/$app/borg.logto the ynh service to be able to see the logs in the webadminPR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)