Manifestv2 #84
Manifestv2 #84
Conversation
|
!testme |
|
Fingers crossed! |
|
!testme |
|
Meow 🐈 |
|
!testme |
|
Meow 🐈 |
|
@Salamandar I made a branch with my version 2. I gave up at one point, so feel free to poke around (I merged your huge source list) |
Oh alright ! got it :) |
|
!testme |
|
Alrighty! |
|
!testme |
|
May the CI gods be with you! |
|
!testme |
|
Fingers crossed! |
|
!testme |
|
✌️ |
|
!testme |
|
May the CI gods be with you! |
|
!testme |
1 similar comment
|
!testme |
|
Alrighty! |
|
!testme |
|
😜 |
|
!testme |
|
✌️ |
|
I still have to ask gitea guys if we really need every minor version of gitea for database upgrades |
|
!testme |
|
Fingers crossed! |
|
!testme |
If I recall correctly, the plan for future packaging is to have a specific path for apps. having |
On my side no user are set as admin on new install. It's a know issue here : #76
No only permissions are supported now. Link with user-group are not managed but I need to investigate what exactly is the feature of this.
Well before merging to testing we MUST test this correctly. I already heard (like this) that it's better to merge to testing and after more people test but the issue with this strategy is that after we merge to master and there are many regression that nobody fix... So no we must take the time to test correctly that everything work before merging this. |
Well |
|
Hello, Well, now I need to push some fix but I don't have any more access right. @Salamandar can you fix it ? Or does I need to create new PR with other branch ? |
Could you instead please make change requests on github ? That’ll help review and discussion :) |
|
@Josue-T Why did you remove the [install.admin] question ? That’s probably why you don’t have admin users… |
|
!testme |
|
Meow 🐈 |
|
!testme |
|
🎠 |
* Move app install dir from /opt to /var/www * Revamp the way binaries are downloaded thanks to manifestv2 (no need to check for arch, etc) * Remove custom helpers (exec_as, ynh_handle_app_migration) * Rename LFS_KEY as LFS_JWT_SECRET and KEY as SECRET_KEY as named in app.ini * Add JWT_SECRET for oauth and INTERNAL_TOKEN in app.ini * update upstream sample app.ini URL * Disable actions for now. * Automatically add ssh permissions to the system user * Remove support for upgrade before 1.6.4. Edit test_upgrade_from accordingly.
* database PATH * JWT_SECRET cleanup app.ini
Forgejo as the same issue cf: https://github.com/YunoHost-Apps/forgejo_ynh/blob/master/manifest.toml#L42 And it look like an upstream issue: go-gitea/gitea#25985 |
Indeed, and I couldn’t make email reception work for now on gitea. Would it be possible to merge this PR on testing first ? I have some other changes I need to merge (gitea logs speak about deprecated config keys, there’s also the issue of the auto-edited config file), and it would be nice to at least have this huge change merged :D |
| - Restart Gitea service: | ||
|
|
||
| ```bash | ||
| systemctl stop __APP__.service |
There was a problem hiding this comment.
| systemctl stop __APP__.service | |
| systemctl restart __APP__.service |
|
|
||
| If you want to use the Git command (like `git clone`, `git pull`, `git push`), you need to set this app as **public**. | ||
| Due of the backup core only feature the data directory in `/home/yunohost.app/__APP__` **is not removed**. It must be manually deleted to purge user data from the app. |
There was a problem hiding this comment.
Why not, but that's the same stuff for every app with a data dir ...
Anyway, nowadays yunohost app remove has a --purge option, and i think with packaging v2 there may be a modal asking admins wether or not to purge data ?
| ynh_systemd_action --service_name="$app" --action="start" --log_path="/var/log/$app/gitea.log" --line_match="Starting new Web server: tcp:127.0.0.1:" | ||
| # FIXME: Leave the time to update the database schema | ||
| sleep 5 | ||
| systemctl stop "$app" |
There was a problem hiding this comment.
| systemctl stop "$app" | |
| ynh_systemd_action --service_name="$app" --action="stop" |
| # previous_maintainers = [ | ||
| # "rafi59" | ||
| # ] |
There was a problem hiding this comment.
| # previous_maintainers = [ | |
| # "rafi59" | |
| # ] |
+1, i don't know what's holding this PR right now, i made a few comments but these really are minor/trivialish stuff |
|
!testme |
|
✌️ |
|
Note I will push some fix this week 😉 |
Problem
Manifestv1 !
Solution
Manifestv2 !
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)