Manifestv2 improvements #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move app install dir from /opt to /var/www * Revamp the way binaries are downloaded thanks to manifestv2 (no need to check for arch, etc) * Remove custom helpers (exec_as, ynh_handle_app_migration) * Rename LFS_KEY as LFS_JWT_SECRET and KEY as SECRET_KEY as named in app.ini * Add JWT_SECRET for oauth and INTERNAL_TOKEN in app.ini * update upstream sample app.ini URL * Disable actions for now. * Automatically add ssh permissions to the system user * Remove support for upgrade before 1.6.4. Edit test_upgrade_from accordingly.
Deprecated config option `[mailer]` `SKIP_VERIFY` present. Use `[mailer]` `FORCE_TRUST_SERVER_CERT` instead. This fallback will be/has been removed in v1.19.0
When we use smtps+starttls we have this error : gomail: could not send email 1: SMTP server does not support AUTH, but credentials provided
when we use other user for email than gitea we have this error: gomail: could not send email 1: failed to issue RCPT command: 553 5.7.1 : Sender address rejected: not owned by user gitea
Fix warning: Failed to load writer mode "router" for logger router: invalid log writer type (mode): router, maybe it needs something like 'MODE=file' in [log.router] section Failed to load writer mode "xorm" for logger xorm: invalid log writer type (mode): xorm, maybe it needs something like 'MODE=file' in [log.xorm] section Fix log level in file because: - warning level break startup service detection (with ynh_systemd_action) - warning level break fail2ban
With the previous config we have this error: Error while processing incoming emails: could not connect to server 'localhost:993': tls: failed to verify certificate: x509: certificate is valid for domain.tld, not localhost
This was
linked to
issues
Feb 6, 2024
Closed
|
!testme |
|
🌻 |
|
!testme |
|
🎠 |
|
!testme |
|
Meow 🐈 |
|
!testme |
|
🌻 |
|
!testme |
|
✌️ |
|
!bookwormtestme |
|
📚 |
|
!testme !bookwormtestme |
|
📚 |
|
✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Note that I've decided to temporately disable the SSO feature untils go-gitea/gitea#18452 is merged (as we can't chose booth SSO and LDAP currently and for now we miss many feature if we don't use LDAP).
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)