Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the inability to upload files to Sharkey drive & a few small changes #29

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

looowizz
Copy link
Contributor

Problem

Solution

  • I altered the systemd sandboxing to allow sharkey to create files in the drive
  • I replaced npm start with pnpm start
  • I removed the redundant comment from the DESCRIPTION.md's

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Thanks!

  • Loowiz

looowizz and others added 4 commits December 26, 2024 19:40
- This patch fixes sharkey not allowing users to upload files to the drive
- I'm also testing using pnpm for the ExecStart rather than npm
Removes the comment about waiting for the release of Yunohost 12/Bookworm
Removes the comment about waiting for the release of Debian 12/Bookworm
@ericgaspar ericgaspar merged commit dc900b9 into YunoHost-Apps:testing Dec 27, 2024
@ericgaspar ericgaspar mentioned this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants