Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate existing READMEs even if translation status has dropped from a lower value than 100% #2233

Closed
wants to merge 0 commits into from

Conversation

oleole39
Copy link
Contributor

@oleole39 oleole39 commented Apr 9, 2024

This is a proposal to improve current behavior which is not to regenerate the README of the given language if that language has not been fully translated on Weblate.
It leads to cases where full translation of a given language was available, but then did not get updated. In this case, a README remains in the repo, not updated and not linked anymore in ALL_README.md.
With this PR, the readme would get generated whatever the current translation status (if no error) but add a warning to the README if not fully translated.

  • It has not been tested
  • Will L.200 get translated or should it be added to the hack section in ALL_README.md.j2 ?
  • Is it a good idea to make DESCRIPTION and DISCLAIMER block impact translation_warning variable (L.127 & L.138), knowing it is not the same translation process (one via Weblate, the other via Github) ?

@Psycojoker
Copy link
Member

I need to test it but LGTM for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants