Add logos_check.py to validate logos filesize/resolution #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def check(self) -> bool: | ||
| self.fails.clear() | ||
| for fn_name in dir(self): |
There was a problem hiding this comment.
Explicitly listing the steps is clearer :)
|
|
||
| def check_type(self) -> None: | ||
| format = self.image.format.lower() | ||
| accepted_formats = ["png", "jpeg", "webp"] |
There was a problem hiding this comment.
Should we accept all those formats? Many software don't support web yet. And JPG doesn't allow background transparency which is nice for dark/light background. I think only PNG should be supported, but we could discuss it on the issue.
There was a problem hiding this comment.
(currently we have .png exclusively in logos/ indeed)
| self.fails.append(f"Image should be one of {', '.join(accepted_formats)} but is {format}") | ||
|
|
||
| def check_dimensions(self) -> None: | ||
| dim_min, dim_max = 96, 300 |
There was a problem hiding this comment.
Could we maybe hardcode those constants at the top of the file for easier changes?
|
|
||
| def check_filesize(self) -> None: | ||
| filesize = self.imgpath.stat().st_size | ||
| max_size = 80_000 |
There was a problem hiding this comment.
Could we maybe hardcode this constant at the top of the file for easier changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See YunoHost/issues#2438