Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration: Pydantic v2 #2001

Merged
merged 23 commits into from
Nov 21, 2024
Merged

Migration: Pydantic v2 #2001

merged 23 commits into from
Nov 21, 2024

Conversation

Axolotle
Copy link
Member

Solution

Migrate to pydantic v2 for trixie.
This is minimal migration with no use of new features (will come in another PR).

PR Status

To test

How to test

Pydantic v2 is not available on bookworm, you can ugly global install it with pip.

pip3 install pydantic --break-system-packages --ignore-installed
pip3 install email-validator --break-system-packages --ignore-installed
pip3 install pydantic_extra_types --break-system-packages --ignore-installed

@Axolotle Axolotle changed the base branch from dev to trixie November 20, 2024 16:52
@Axolotle Axolotle changed the base branch from trixie to dev November 20, 2024 16:53
@Salamandar
Copy link
Contributor

Well I'd say we should merge this on the trixie branch (or, find a way to properly install pydantic v2 on bookworm ?)

@Axolotle Axolotle changed the base branch from dev to trixie November 20, 2024 23:59
@Salamandar Salamandar mentioned this pull request Nov 21, 2024
Draft
3 tasks
@Salamandar Salamandar self-requested a review November 21, 2024 14:36
Salamandar
Salamandar approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Salamandar Salamandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully working but this is expected. LGTM.

@Axolotle @Salamandar
pydanticv2: Model.dict() -> Model.dump_model()
b8f098f
@Axolotle @Salamandar
pydanticv2: Model.__fields__ -> Model.model_fields
f0303aa
@Axolotle @Salamandar
pydanticv2: Model.construct() -> Model.model_construct()
0c74ed6
@Axolotle @Salamandar
pydanticv2: Class Config -> ConfigDict()
68e9eb6
@Axolotle @Salamandar
pydanticv2: Class Config.schema_extra() -> __get_pydantic_json_schema…
aedbcab 
…__()
@Axolotle @Salamandar
pydanticv2: validator() -> field_validator()
29166b7
@Axolotle @Salamandar
pydanticv2: root_validator() -> model_validator()
ad1073a
@Axolotle @Salamandar
pydanticv2: Field's allow_mutation -> frozen
8c38c8d
@Axolotle @Salamandar
pydanticv2: regex -> pattern
14982e6
@Axolotle @Salamandar
pydanticv2: fix missing imports
d29545d
@Axolotle @Salamandar
pydanticv2: rework custom validators and extra args
42a9947
@Axolotle @Salamandar
pydanticv2: fix SelectOption and other choices options
8626711
@Axolotle @Salamandar
pydanticv2: fix TimeOption, was no longer parsing numbers
3e88242
@Axolotle @Salamandar
pydanticv2: fix DateOption, was no longer parsing numbers
22847c6
@Axolotle @Salamandar
pydanticv2: fix PasswordOption, properly handle forbidden fields
b97230f
@Axolotle @Salamandar
pydanticv2: 'ask' as optional
7c81896
@Axolotle @Salamandar
pydanticv2: fix missing imports
aaa87ac
@Salamandar Salamandar marked this pull request as ready for review November 21, 2024 14:40
@Salamandar Salamandar merged commit 2b5514d into trixie Nov 21, 2024
@Salamandar Salamandar deleted the pydantic-v2 branch November 21, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salamandar Salamandar Salamandar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Axolotle @Salamandar