Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 将 groq 翻译重构为 openai 通用翻译 #371

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

ikxin
Copy link
Contributor

@ikxin ikxin commented Sep 24, 2024

@ikxin
Copy link
Contributor Author

ikxin commented Sep 24, 2024

@glyh 请求 review code

@glyh
Copy link
Collaborator

glyh commented Sep 24, 2024

请问你本地测试可以运行用openai的翻译,没问题对吧

@glyh glyh self-assigned this Sep 24, 2024
Copy link
Collaborator

@glyh glyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 我似乎没有通过PR的权限,所以应该还是要等Yuukiy决定

@ikxin
Copy link
Contributor Author

ikxin commented Sep 24, 2024

@glyh 非常抱歉我没有 OpenAI 官方的 API 用于测试,不过我测试了两个第三方的 API 和 Groq 的 API,均可以正常工作,理论上只要是兼容 OpenAI 官方 API 的应该都能使用

@ikxin
Copy link
Contributor Author

ikxin commented Sep 24, 2024

补充一下,个人感觉 Groq 比 GPT 3.5 的模型翻译效果要更好一些

QQ_1727170327061

@glyh glyh merged commit 2618998 into Yuukiy:master Sep 24, 2024
@glyh
Copy link
Collaborator

glyh commented Sep 24, 2024

Figured out, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants