Move '@material-ui/icons' to 'peerDependencies' #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to merge this PR ASAP, as material-ui-dropzone is broken with yarn 2.0. |
|
Hi @eluchsinger , If you need to use this module I'd suggest you to use my branch directly (until this PR gets merged). I made some other improvements not included in this PR about the packaging and dependencies, you can add
yarn add https://github.com/panz3r/material-ui-dropzone#4ca2b3e93b591fb4a7eda70261546c93bfa06907
yarn add https://github.com/panz3r/material-ui-dropzone#666e214963e5f9be508b3a4b285945c606289d91Let me know if this helps you. P.S. I'd like to become a maintainer for this project but I'm waiting for a response from the owner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
@material-ui/iconsdependency definition topeerDependenciesto avoid including an older version (v3.0.2) of@material-ui/iconson projects that are already using@material-ui/iconsv4 or later andmaterial-ui-dropzone.Also indirectly fixes a new deprecation warning thrown by
react 16.13.0because of how the old@material-ui/iconsversion was bundling icons.Fix #95 .