Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Prevent control focus rubber band drawing round the negative ma… #156

Merged
merged 1 commit into from
May 5, 2020

Conversation

max-carroll
Copy link
Contributor

@max-carroll max-carroll commented May 5, 2020

Prevent control focus rubber band drawing round the negative margin outsize the dropzone caused by MUI Grid container spacing

Description

In some scenarios the rubber band of the focused dropzone is taking a funny shape due to the negative margin created by the PreviewList Grid container spacing.

According to an article (cited in the issue) one of the easiest ways to fix this was by setting overflow to hidden on the containing div which in this case is the dropzone div.

Before my code changes it looks like this

2020-05-05_12h23_40

After it looks like this

2020-05-05_12h25_08

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  • Test A - Checked it looked identical with and without the css change other than the rubber band for 2 files
  • Test B - Checked it looked identical with and without the css change other than the rubber band for 8 files - to ensure that the box could still grow vertically even though the overflow was hidden

Test Configuration:

  • Browser:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

… outsize the dropzone caused by MUI Grid container spacing
@max-carroll
Copy link
Contributor Author

Okay this is ready for review 😄

@max-carroll max-carroll mentioned this pull request May 5, 2020
@topninja
Copy link

topninja commented May 5, 2020

Looks great

Copy link
Contributor

@panz3r panz3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks @max-carroll, this should be checked on and backported to v2.x.

@panz3r panz3r added the bug label May 5, 2020
@panz3r panz3r added this to the 3.1 milestone May 5, 2020
@panz3r panz3r merged commit 5b9cfda into Yuvaleros:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outline css
3 participants