Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controlled components #175

Merged
merged 7 commits into from
May 27, 2020
Merged

Add controlled components #175

merged 7 commits into from
May 27, 2020

Conversation

panz3r
Copy link
Contributor

@panz3r panz3r commented May 27, 2020

Description

This PR introduces 2 new components (DropzoneAreaBase and DropzoneDialogBase) which are the new 'stateless' base for DropzoneArea and DropzoneDialog (which are now simple wrapper to add state).

The 2 base components are exported to allow 'controlled' usages as previously requested.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Interactive docs testing

Test Configuration:

  • Browser: Edge 81

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@panz3r panz3r added this to the 3.2 milestone May 27, 2020
@panz3r panz3r self-assigned this May 27, 2020
@panz3r panz3r merged commit b4cc6df into Yuvaleros:master May 27, 2020
@panz3r panz3r deleted the controlled-components branch May 27, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputProps not working when setting files prop to an array of files Possibility to override file uploaded
1 participant