Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show remove buttons when they have focus. #191

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

MatthijsMud
Copy link
Contributor

Description

Show the "remove image"-button when it has keyboard focus.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  1. Run yarn docs:dev.
  2. Open the link listed in the console (localhost:6060).
  3. Upload a file in one of the dropzones.
  4. Press tab on the keyboard.

Test Configuration:

  • Browser: FireFox 76.0

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MatthijsMud MatthijsMud changed the title 🐛 Show remove buttons when they have focus. Show remove buttons when they have focus. Jun 7, 2020
@panz3r panz3r self-requested a review June 7, 2020 12:13
@panz3r panz3r added the bug label Jun 7, 2020
@panz3r panz3r added this to the 3.2 milestone Jun 7, 2020
@panz3r
Copy link
Contributor

panz3r commented Jun 7, 2020

Hi @MatthijsMud ,

Thanks for your support, LGTM 👍 .

Can you please update your commit message to comply with Gitmoji commit convention?
Thanks again.

@MatthijsMud
Copy link
Contributor Author

Changed the commit message to include the 🐛 emoji.

@panz3r panz3r merged commit da265ee into Yuvaleros:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove button not visible despite having keyboard focus
2 participants