Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Snackbar theme override #198

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Fixes for Snackbar theme override #198

merged 2 commits into from
Jun 10, 2020

Conversation

panz3r
Copy link
Contributor

@panz3r panz3r commented Jun 10, 2020

Description

This PR changes the Snackbar variant class names to avoid conflict with Material UI internals when overriding styling through theme.

Also adds an example of how to override styles using Theme API.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  • Interactive docs testing

Test Configuration:

  • Browser: Edge 83

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@panz3r panz3r added the bug label Jun 10, 2020
@panz3r panz3r added this to the 3.2 milestone Jun 10, 2020
@panz3r panz3r self-assigned this Jun 10, 2020
@panz3r panz3r merged commit 6dea851 into master Jun 10, 2020
@panz3r panz3r deleted the snackbar-theme-fixes branch June 10, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@panz3r panz3r

Labels
bug
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Mui Theme support question (or bug)
1 participant
@panz3r