feat: improves onDelete, dropzoneText and docs #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you give this a look please @panz3r? |
panz3r
suggested changes
Nov 6, 2021
| @@ -1,17 +1,17 @@ | |||
| # material-ui-dropzone | |||
There was a problem hiding this comment.
Revert changes to README.md or exclude them from this PR.
| @@ -1,7 +1,8 @@ | |||
| # material-ui-dropzone | |||
There was a problem hiding this comment.
Revert changes to docs/intro.md or exclude them from this PR.
| @@ -1,14 +1,9 @@ | |||
| This is the Dialog component: | |||
There was a problem hiding this comment.
Revert changes to docs/screenshots.md or exclude them from this PR.
| @@ -15,7 +15,7 @@ module.exports = { | |||
| content: './docs/support.md', | |||
| }, | |||
| { | |||
| name: 'Screenshots', | |||
| name: 'Demo', | |||
|
Thanks for the review. I've seen it before, but just got from holidays. Will be addressing this the upcoming week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds 3 contributions:
How Has This Been Tested
All of the changes done here have been tested on a project consuming my fork version.
Both
onDeleteand dropzoneText using react elements seem to work fine.Checklist