Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add permutation unit tests #7300

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

ChuyueSun
Copy link
Contributor

@ChuyueSun ChuyueSun commented Jul 19, 2024

The old unit test does not run at all.

@NikolajBjorner
Copy link
Contributor

/usr/bin/clang++ -D_EXTERNAL_RELEASE -D_MP_INTERNAL -I/home/vsts/work/1/s/build/src -I/home/vsts/work/1/s/src -Werror=odr -Werror=return-type -Werror=delete-non-virtual-dtor -Werror=overloaded-virtual -Werror=non-virtual-dtor -Werror=null-dereference -fcolor-diagnostics -O2 -g -DNDEBUG -std=gnu++17 -mfpmath=sse -msse -msse2 -Wall -MD -MT src/test/CMakeFiles/test-z3.dir/permutation.cpp.o -MF src/test/CMakeFiles/test-z3.dir/permutation.cpp.o.d -o src/test/CMakeFiles/test-z3.dir/permutation.cpp.o -c /home/vsts/work/1/s/src/test/permutation.cpp
/home/vsts/work/1/s/src/test/permutation.cpp:2:10: fatal error: 'permutation.h' file not found
#include "permutation.h"
^~~~~~~~~~~~~~~
1 error generated.

/*++
Copyright (c) 2012 Microsoft Corporation
#include <iostream>
#include "permutation.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the include path should be "util/permutation.h"

@NikolajBjorner
Copy link
Contributor

I guess you need to include something for in permutation.cpp. The build on mac says:

../src/test/permutation.cpp:81:24: error: implicit instantiation of undefined template 'std::basic_ostringstream'
std::ostringstream out;
^
/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/iosfwd:141:32: note: template is declared here
class _LIBCPP_TEMPLATE_VIS basic_ostringstream;
^
1 error generated.

@NikolajBjorner
Copy link
Contributor

The unit test fails

@NikolajBjorner NikolajBjorner merged commit 6ba25b8 into Z3Prover:master Aug 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants