Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettifying license. #982

Closed
wants to merge 1 commit into from
Closed

Prettifying license. #982

wants to merge 1 commit into from

Conversation

JulienPalard
Copy link

For readability, wrapping around 80th column is nice, but also I fixed the:

""Software"" to "Software".

I tried not to modify the license more than this, so I kept your
header almost unchanged:

Z3
Copyright (c) Microsoft Corporation
All rights reserved.

MIT License

I just removed a trailing whitespace at the end of `All rights reserved``.

Note that your header still not match the
https://opensource.org/licenses/MIT template, you're missing the year
in the Copyright notice. I personally don't care, but you should check
this with your legal team.

For readability, wrapping around 80th column is nice, but also I fixed the:

""Software"" to "Software".

I tried not to modify the license more than this, so I kept your
header almost unchanged:

```
Z3
Copyright (c) Microsoft Corporation
All rights reserved.

MIT License
```

I just removed a trailing whitespace at the end of `All rights reserved``.

Note that your header still not match the
https://opensource.org/licenses/MIT template, you're missing the year
in the Copyright notice. I personally don't care, but you should check
this with your legal team.
@msftclas
Copy link

@JulienPalard,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@JulienPalard, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@wintersteiger
Copy link
Contributor

Looks fine to me, but I'm not sure we should merge this change. So far I assumed that the formatting should be the same as on opensource.org, but I guess it doesn't make a big difference.

@NikolajBjorner
Copy link
Contributor

As far as I can see Julien's updates does get the text aligned with that on http://opensource.org. Maybe his crawler started barking when it hit this.
I don't know why we have double quotes around "Software". It reminds me of something like http://knowyourmeme.com/photos/594192-dr-evil-air-quotes.

@JulienPalard
Copy link
Author

What my parser disliked the most was the double-double-quote, looks like the only important thing to fix.

Second important thing, if you want to keep your license unwrapped like in opensource.org you should at least also keep blank lines between paragraphs, it helps with readability.

For the wrapping around ~80 column, that's just for readability, for humans: I just though "as I'm doing a pull requests for this, let's do something as clean as possible" (so I even removed ugly-invisible trailing whitespaces…).

NikolajBjorner added a commit that referenced this pull request Apr 26, 2017
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
@NikolajBjorner
Copy link
Contributor

I removed double quotes and added new lines per. Kept the wrap-around for now.

@JulienPalard
Copy link
Author

Works for me, take care!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants