Defere loading to ensure translations work #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I discovered a bit of a funny bug: The translation of components in blocks is actually only working because of the package name starting with "z": Z3d0X/...
The translation service is not available at the time the blocks are registered so translations will be completely ignored.
This is easily demonstrated in this repo: https://github.com/martin-ro/fabricator-translation
I've cloned
z3d0x/filament-fabricator
into the packages directory and changed the name to "aaaz3d0x/filament-fabricator". You'll see that a CuratorPicker for example is not translated anymore.This really is an edge case and only affects packages that are alphabetically after "z3d0x" loaded (that's how I discovered it).
However, I think it's still a bug worth fixing. If you ever move the package into another namespace it will break for everyone depending on naming.
This PR implements https://laravel.com/docs/11.x/providers#deferred-providers:
Personally, I only use the blocks and nothing else. I don't know how that would interfere with the rest of the package.
What do you think @Z3d0X ?
Best,
Martin