hotfix: Proper clearing of the ID<->URI mappings #204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing the last entries of any of the two ID<->URI mappings, the cached value used to become an empty array, which in turn broke all read operations from said mapping and thus most of the features related to routing.
The bug could only occur in three situations:
hook-to-commands
config option set totrue
, when calling any of theclear
kind of 1st-party artisan commands (note that some commands likeroute:cache
also silently callroute:clear
first, so these count as well)true
)This PR addresses this issue by removing the mapping from the cache instead of caching an empty mapping. This effectively clears out the mapping and properly invalidates caches.
Fixes #198