Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Third Party License text #24

Merged
merged 61 commits into from
Nov 13, 2024
Merged

Update Third Party License text #24

merged 61 commits into from
Nov 13, 2024

Conversation

m-aXimilian
Copy link
Contributor

@m-aXimilian m-aXimilian commented Nov 12, 2024 •
edited
Loading

Description

PR #22 added a dependency to rapdijson which has to be declared in the third party license text.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

no functional changes -> no tests required

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

m-aXimilian and others added 30 commits August 19, 2024 18:44
@m-aXimilian
check if the specified channels in the appliance metadata exits
9911158
@m-aXimilian
linter fix & version history update
6e3bb7d
@m-aXimilian
rm commented code & add documentation
76575b1
@m-aXimilian
bump version
1b56589
@m-aXimilian
add new test
1c591a4
@m-aXimilian
review update 1 - C-Dimension return check
995139a
@m-aXimilian
review 2 - std::all_of > std::for_each
03f9fd7
@m-aXimilian
review 3 - referencing constants
eca697e
@m-aXimilian
review 4 - check given set
498de1e
@m-aXimilian
Merge branch 'ZEISS:main' into main
3002233
@m-aXimilian
Merge branch 'ZEISS:main' into main
0478872
@m-aXimilian
add output encoding commandline option
4f5ed8f
@m-aXimilian
first initial hack with rapidjson
3c10da1
@m-aXimilian
towards resultgatherer interface
51085e3
@m-aXimilian
cleanup
6a83187
@m-aXimilian
add xml result gatherer based on pugixml
18c949f
@m-aXimilian
introduce factorymethod for result gatherers
a6f5e8e
@m-aXimilian
fix xml versioning
2c6ebe2
@m-aXimilian
fix linux build
84b9371
@m-aXimilian
make megalinter happy
c17f292
@m-aXimilian
whitespace fixes
7374e36
@m-aXimilian
remove tabs
6540806
add aggregated result to the root node
2f3564a
extract string constants json gatherer
e398195
extract string constants xml gatherer
8111164
megalinter happiness
0373033
remove useless lambdas
127e9c5
indentation fail
c0b4116
@m-aXimilian
rm commented code
8b3316c
@m-aXimilian
gatherer factory method implementation file
079c3c0
@m-aXimilian m-aXimilian added the cla Contributor License Agreement sent to Admin label Nov 12, 2024
@m-aXimilian m-aXimilian marked this pull request as ready for review November 12, 2024 12:52
DaveyJonesBitPail
DaveyJonesBitPail approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@m-aXimilian m-aXimilian merged commit 377e033 into ZEISS:main Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveyJonesBitPail DaveyJonesBitPail DaveyJonesBitPail approved these changes

Assignees
No one assigned
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-aXimilian @DaveyJonesBitPail