Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update of xsd (adding new "compression"-elements) #4

Merged
merged 6 commits into from
Dec 8, 2023
Merged

update of xsd (adding new "compression"-elements) #4

merged 6 commits into from
Dec 8, 2023

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Dec 7, 2023

Description

  • update of metadata-schema (adding some new elements related to "compression")
  • add a changelog

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally, unittests

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose requested a review from a team December 7, 2023 11:23
@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Dec 7, 2023
DaveyJonesBitPail
DaveyJonesBitPail previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions/recommendations

@ptahmose ptahmose requested a review from a team December 7, 2023 21:57
@ptahmose ptahmose merged commit 7eaea81 into ZEISS:main Dec 8, 2023
7 checks passed
@ptahmose ptahmose deleted the jbl/update_xsd_compression branch December 8, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveyJonesBitPail DaveyJonesBitPail DaveyJonesBitPail approved these changes

Assignees
No one assigned
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptahmose @DaveyJonesBitPail