Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checker for "decoding compressed data" #9

Merged
merged 20 commits into from
Mar 26, 2024

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Mar 24, 2024

Description

Add a new checker "subblkbitmapvalid". It decodes compressed data and checks the consistency of the compressed bitmap.

Fixes #7

Sample output:

PS D:\> .\CZICheck.exe -s L:\Liqu_form_M_MZ0333_Zx005_Ni_15.czi   -d true
Test "check subblock's coordinates for 'consistent dimensions'" : OK
Test "SubBlock-Segment in SubBlockDirectory within file" : OK
Test "check subblock's coordinates being unique" : OK
Test "check whether the document uses the deprecated 'B-index'" : OK
Test "check that the subblocks of a channel have the same pixeltype" : OK
Test "Check that planes indices start at 0" : OK
Test "Check that planes have consecutive indices" : OK
Test "check if all subblocks have the M index" : OK
Test "Basic semantic checks of the XML-metadata" : OK
Test "check if subblocks at pyramid-layer 0 of different scenes are overlapping" : OK
Test "SubBlock-Segments in SubBlockDirectory are valid and valid content" :
  Error decoding subblock #5 with compression "jpgxr"
  details: size mismatch: expected 1024x978, but got 1024x977
  Error decoding subblock #6 with compression "jpgxr"
  details: size mismatch: expected 1024x978, but got 1024x977
  Error decoding subblock #7 with compression "jpgxr"
  details: size mismatch: expected 1024x978, but got 1024x977
  <392 more findings omitted>
 FAIL


Result: Errors Detected

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • tested with a problematic CZI
  • added test-cases with synthetic CZI

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Mar 24, 2024
@ptahmose ptahmose requested a review from a team March 24, 2024 21:25
CZICheck/checkers/checkerSubBlkBitmapValid.cpp Outdated Show resolved Hide resolved
CZICheck/checkers/checkerSubBlkBitmapValid.h Outdated Show resolved Hide resolved
CZICheck/checkers/checkerSubBlkBitmapValid.h Outdated Show resolved Hide resolved
documentation/usage.md Show resolved Hide resolved
Co-authored-by: DaveyJonesBitPail <119518234+DaveyJonesBitPail@users.noreply.github.com>
ptahmose and others added 2 commits March 25, 2024 14:58
Co-authored-by: DaveyJonesBitPail <119518234+DaveyJonesBitPail@users.noreply.github.com>
Co-authored-by: DaveyJonesBitPail <119518234+DaveyJonesBitPail@users.noreply.github.com>
m-aXimilian
m-aXimilian previously approved these changes Mar 25, 2024
@ptahmose ptahmose dismissed stale reviews from DaveyJonesBitPail and m-aXimilian via 58ce49d March 26, 2024 09:27
@ptahmose ptahmose merged commit b00354b into ZEISS:main Mar 26, 2024
7 checks passed
@ptahmose ptahmose deleted the jbl/decode_subblocks branch March 26, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checker which "decodes data"
3 participants