Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third party license update #121

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Third party license update #121

merged 1 commit into from
Nov 15, 2024

Conversation

m-aXimilian
Copy link
Contributor

Description

The project can include rapidjson (for CZICmd).
This is now eplicitely reflected in the third party license text.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

No functional changes.

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@m-aXimilian m-aXimilian added the cla Contributor License Agreement sent to Admin label Nov 15, 2024
@m-aXimilian m-aXimilian changed the title Third party licenseupdate Third party license update Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.47%. Comparing base (8474da3) to head (1f9182c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   65.47%   65.47%           
=======================================
  Files          86       86           
  Lines       10898    10898           
=======================================
  Hits         7136     7136           
  Misses       3762     3762           
Flag Coverage Δ
windows-latest 65.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-aXimilian m-aXimilian marked this pull request as ready for review November 15, 2024 12:17
@m-aXimilian m-aXimilian merged commit d615ba9 into ZEISS:main Nov 15, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants